fix: allow use of CheckGroupRef in the Checkly config file #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorccu
deleted the
simo/sim-167-cli-checkgroupref-not-supported-in-checkly-config-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Components
Notes for the Reviewer
CheckGroupRefwas mistakenly not allowed to be used in a Checkly configuration file. The reason why constructs are not allowed in the config file by default is that many of them require information from the configuration file, such as default values, which are not available until the configuration file has been fully loaded. However, there is no such concern forCheckGroupRefbecause it does not rely on any additional data from the configuration file.I verified both the presence of the issue and the effectiveness of the fix manually. In the interest of pushing this change out ASAP no time was spent on adding tests.
New Dependency Submission